search

OCA / storage

GNU Affero General Public License v3.0
66 stars 148 forks source link

[16] fs_storage : Allow to choose different method to check connection #357

Closed florian-dacosta closed 2 months ago

florian-dacosta commented 3 months ago

Since https://github.com/OCA/storage/pull/320, in order to resolve some cache issues, the way to check connection did change and became mandatory (which was not the case before)

Now, a marker file is created on remote server which is then read each time we need to connect. I did ran into some issues because of this on server with limited access rights.. (Not allowed to write in the remote server for instance). Another issue is that some partners don't expect Odoo to send these kind of files (the marker files) and their system is not able to ignore it for instance.

I find this way quite intrusive, when connecting to remote server that are managed by external partners. We could have to deal with a server with read-only access, and this is not possible anymore.

To solve this issue, I propose to give an option on the fs storage on how the connection should be checked. By default, the mark file stuff is set, but you could choose or implement other methods it this one does not work for your case.

I did implement the one we had before (list file on the whole folder), but I think it is valid to implement still other methods if necessary.

@hparfr @lmignon @JordiMForgeFlow @sebalix @nilshamerlinck

JordiMForgeFlow commented 3 months ago

For me it looks good to have the option to decide, I would just maybe recommend to add some description in the README on the implications of using each method.

florian-dacosta commented 3 months ago

I am not sure we want to go into such detail in the README, but at least a help on the field to describe each option would be nice indeed

florian-dacosta commented 2 months ago

For me it looks good to have the option to decide, I would just maybe recommend to add some description in the README on the implications of using each method.

Done @JordiMForgeFlow

lmignon commented 2 months ago

@JordiMForgeFlow can you take a look at last changes?

lmignon commented 2 months ago

/ocabot merge minor

OCA-git-bot commented 2 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-357-by-lmignon-bump-minor, awaiting test results.

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at b2d641a58212420d40a4fda0e1e96aac944d1b5d. Thanks a lot for contributing to OCA. ❤️