search

OCA / storage

GNU Affero General Public License v3.0
66 stars 148 forks source link

[17.0][IMP] fs_storage: replace {db_name} in directory_path #379

Open vincent-hatakeyama opened 1 week ago

vincent-hatakeyama commented 1 week ago

In multi database mode, there was no way to avoid filename collisions.

In multi database mode, without using that feature in fs_attachment, as the created filename does not contain the database name, it is possible to overwrite files from another database if obfuscation is off and the file have the same name and the same id or cause deletion of files if the checksum is used as the name and the same file is copied over several database and unlinked in one of them. I would have prefer for the name of the file to always include the database name but I think it would have been a major change considered too breaking. Allowing to use the database name seemed more compatible.

lmignon commented 1 week ago

@vincent-hatakeyama you should use one backend by database. IMO this change is useless.