OCA / survey

Survey addons
GNU Affero General Public License v3.0
27 stars 110 forks source link

[8.0][ADD][survey_one_choice_per_column] Restrict answers (one answer per column) on a matrix #15

Closed tarteo closed 8 years ago

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-55.6%) to 44.444% when pulling 670b1751c89b388da74f48d7f135cf1ef579e8b1 on onesteinbv:80_add_survey_one_choice_per_column into dd0c4dd35e441481bf0f31851721f4f9fb60fd44 on OCA:8.0.

tarteo commented 8 years ago

@elicoidal Thank you for your feedback.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-55.6%) to 44.444% when pulling d3745999c72286a77cc8a8e4973b1a00d76392e7 on onesteinbv:80_add_survey_one_choice_per_column into dd0c4dd35e441481bf0f31851721f4f9fb60fd44 on OCA:8.0.

astirpe commented 8 years ago

:+1:

ehahouimohssine commented 8 years ago

:+1: Tested the functionality

rafaelbn commented 8 years ago

Hi thans a lot for this:

As commented with @hbrunn please add test to you code

"untested coded needs fixing in my book, and the conventions seem to agree: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#tests"

Thanks. I will test it when coverage it solved.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-55.6%) to 44.444% when pulling 0112d74d46c83c4636e475e2e79e942b8b12e5d6 on onesteinbv:80_add_survey_one_choice_per_column into dd0c4dd35e441481bf0f31851721f4f9fb60fd44 on OCA:8.0.

rafaelbn commented 8 years ago

Hi @tarteo now travis fails

tarteo commented 8 years ago

@rafaelbn I'm still working on the unit tests, I will clean the code when I'm finished.

rafaelbn commented 8 years ago

OK! Thanks! :smiley:

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-9.3%) to 90.741% when pulling 3ff71030b4c50b7151cea44871ae372abc9df84a on onesteinbv:80_add_survey_one_choice_per_column into dd0c4dd35e441481bf0f31851721f4f9fb60fd44 on OCA:8.0.

tarteo commented 8 years ago

@rafaelbn I finished the unit tests.

rafaelbn commented 8 years ago

Thanks a lot @tarteo functionally :+1: Could you please review coverage? It is still red.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 880c418c7528efc3f40a858f67244fe9866bf889 on onesteinbv:80_add_survey_one_choice_per_column into dd0c4dd35e441481bf0f31851721f4f9fb60fd44 on OCA:8.0.