[10.0][ADD] - Survey five stars question type

[sbejaoui]

first commit for Survey five stars question type

[oca-clabot]

Hey @sbejaoui, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla Here is a list of the users:

• @sbejaoui-Acsone (login unknown in OCA database)

Appreciation of efforts, OCA CLAbot

[pedrobaeza]

Please avoid plurals on the name, and following usual conventions, the name should be survey_question_type_five_star.

[pedrobaeza]

Check also Travis status

[sbidoul]

Hi all, thanks for the review. We have limited budget to finalize this.

I see one important issue: "When I make a question mandatory, I still can skip it.". @sbejaoui is that easy to fix?

@tarteo Making the number of stars configurable looks too complex for our budget. May be we can rename the module to survey_question_type_star, and leave the configurability for later.

[sbidoul]

[updated] module name in previous comment

[sbidoul]

@benwillig I understand your comments are nice to have refactorings. Are they blocking for you?

[sbejaoui]

@sbidoul , @tarteo , For the mandatory option, I think we should decide if we consider 0 as a valid answer or not. When user skip a question and any of the five stars is highlighted a 0 value is sent. In this case the mandatory option make no sens. So I propose to consider valid answer for mandatory question from 1 to 5.

[sbejaoui]

@tarteo , I pushed a fix for the jslint

[sbejaoui]

Hi @rafaelbn ,

I believe this can be merged

[github-actions[bot]]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.