OCA / timesheet

Odoo Timesheet Management Addons

GNU Affero General Public License v3.0

125 stars 348 forks source link

Migration to version 17.0 #617

Open OCA-git-bot opened 1 year ago

OCA-git-bot commented 1 year ago

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

Modules to migrate

[x] crm_timesheet - By @RogerSans - #700
[ ] hr_timesheet_begin_end
[ ] hr_timesheet_employee_analytic_tag
[ ] hr_timesheet_name_customer
[x] hr_timesheet_sheet - By @SodexisTeam - #687
[ ] hr_timesheet_sheet_policy_project_manager
[x] hr_timesheet_task_domain - By @victoralmau - #721
[x] hr_timesheet_task_required - By @MohamedOsman7 - #640
[x] hr_timesheet_task_stage - By @RogerSans - #701
[ ] hr_timesheet_time_type
[ ] sale_timesheet_line_exclude
[x] sale_timesheet_rounded - By @sonhd91 - #659
[x] sale_timesheet_timeline - By @carlos-lopez-tecnativa - #722

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

francesco-ooops commented 1 year ago

@OCA/human-resources-maintainers pin?

michaelhofer-slg commented 12 months ago

Is anybody actively working on the hr_timesheet_begin_end module migration? Since we need this for our Odoo 17 instance, I would offer myself to migrate this.

pedrobaeza commented 12 months ago

Nobody has claimed it, so go ahead with it

mde-scopea commented 10 months ago

crm_timesheet #631

NICO-SOLUTIONS commented 10 months ago

hr_timesheet_begin_end #632

MohamedOsman7 commented 9 months ago

sale_timesheet_line_exclude #639

MohamedOsman7 commented 9 months ago

hr_timesheet_task_required #640

RogerSans commented 4 months ago

Working on crm_timesheet https://github.com/OCA/timesheet/pull/700

RogerSans commented 4 months ago

Working on https://github.com/OCA/timesheet/pull/701

Tisho99 commented 4 months ago

The hr_timesheet_task_domain module does not seem to require a migration to version 17.

Reason: The module description says that it limits task selection in timesheets to currently-selected project, and tasks in any of "Open" stages. However:

Since v16 odoo already limits task selection in timesheets to currently-selected project
Since v16 there is no "Open" nor "Closed" state in task stages
The module does not seem to do nothing in v16 (correct me if i am wrong). It only adds a badly formed domain: https://github.com/OCA/timesheet/blob/6881261ad419560b02e838bf4cca05423577bdc0/hr_timesheet_task_domain/models/account_analytic_line.py#L13-L20

pedrobaeza commented 4 months ago

@Tisho99 it's not malformed. It's using the feature of parsing expressions at client side to put one domain or the other depending if project_id is filled or not, and that's the value that the module is adding. The field fold is the one to consider a task like finishing one or not.