OCA / vertical-association

Odoo addons for membership related tasks
GNU Affero General Public License v3.0
38 stars 112 forks source link

[16.0][MIG] membership_extension #132

Closed carmenbianca closed 1 year ago

carmenbianca commented 1 year ago

Ping @robinkeunen @PierrickBrun

We may need to drop the commit '[FIX] membership_extension: Use latest start date for Membership Last Start Date' awaiting the resolving of #126

oca-clabot commented 1 year ago

Hey @carmenbianca, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla Here is a list of the users:

Appreciation of efforts, OCA CLAbot

carmenbianca commented 1 year ago

@PierrickBrun The CI is now green :green_circle:

rafaelbn commented 1 year ago

/ocabot migration membership_extension

carmenbianca commented 1 year ago

@gurneyalex Apologies for the many pings. This also needs CLA verification. Thank you! :1st_place_medal:

legalsylvain commented 1 year ago

Hi @carmenbianca. I have a warning on the install :

2022-10-17 14:50:09,922 45215 WARNING pos_membership_extension odoo.addons.base.models.ir_model: Two fields (membership_categories, membership_category_ids) of res.partner() have the same label: Membership Categories. [Modules: membership_extension and membership_extension]

I guess that the second field membership_categories is a technical ones, and could be named 'Technical Membership Categories'. but not sure.

regards.

rafaelbn commented 1 year ago

/ocabot rebase

OCA-git-bot commented 1 year ago

@rafaelbn The rebase process failed, because command git push --force coopiteasy tmp-pr-132:16.0-mig-membership_extension failed with output:

remote: Permission to coopiteasy/vertical-association.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/coopiteasy/vertical-association/': The requested URL returned error: 403
carmenbianca commented 1 year ago

@rafaelbn rebased

rafaelbn commented 1 year ago

Please @fcvalgar ! Thank you!

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 1 year ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-132-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 005a3c45078bfba8d2a0d4cb999d928c2ac139ce. Thanks a lot for contributing to OCA. ❤️