OCA / vertical-association

Odoo addons for membership related tasks
GNU Affero General Public License v3.0
38 stars 112 forks source link

[16.0][MIG] membership_variable_period #133

Closed carmenbianca closed 1 year ago

carmenbianca commented 1 year ago

Migrated from v14.0. Tagging @flachica from #130

Ping @robinkeunen @PierrickBrun

rafaelbn commented 1 year ago

/ocabot rebase

OCA-git-bot commented 1 year ago

@rafaelbn The rebase process failed, because command git push --force coopiteasy tmp-pr-133:16.0-mig-membership_variable_period failed with output:

remote: Permission to coopiteasy/vertical-association.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/coopiteasy/vertical-association/': The requested URL returned error: 403
rafaelbn commented 1 year ago

/ocabot migration membership_variable_period

carmenbianca commented 1 year ago

@rafaelbn rebased

rafaelbn commented 1 year ago

Runboat log

+ bash /runboat/runboat-clone-and-install.sh
+ rm -fr '/mnt/data/*'
+ rm -fr /mnt/data/odoo-addons-dir
+ mkdir -p /mnt/data/odoo-addons-dir
+ cd /mnt/data/odoo-addons-dir
+ curl -sSL https://github.com/oca/vertical-association/tarball/d370881ab90cf5e0195d38e27df3f34a440e9d30
+ tar zxf - --strip-components=1
+ INSTALL_METHOD=oca_install_addons
+ [[ oca_install_addons == \o\c\a\_\i\n\s\t\a\l\l\_\a\d\d\o\n\s ]]
+ oca_install_addons
+ setuptools-odoo-get-requirements --include-addons --addons-dir /mnt/data/odoo-addons-dir
/root/.local/pipx/shared/lib/python3.8/site-packages/_distutils_hack/__init__.py:18: UserWarning: Distutils was imported before Setuptools, but importing Setuptools also replaces the `distutils` module in `sys.modules`. This may lead to undesirable behaviors or errors. To avoid these issues, avoid using distutils directly, ensure that setuptools is installed in the traditional way (e.g. not an editable install), and/or make sure that setuptools is always imported before distutils.
  warnings.warn(
/root/.local/pipx/shared/lib/python3.8/site-packages/_distutils_hack/__init__.py:33: UserWarning: Setuptools is replacing distutils.
  warnings.warn("Setuptools is replacing distutils.")
+ cat test-requirements.txt
odoo-addon-membership_extension>=16.0dev,<16.1dev
odoo>=16.0a,<16.1dev
+ pip install -r test-requirements.txt
Looking in indexes: https://wheelhouse.odoo-community.org/oca-simple-and-pypi
ERROR: Could not find a version that satisfies the requirement odoo-addon-membership_extension<16.1dev,>=16.0dev (from versions: 15.0.1.0.0.3)
ERROR: No matching distribution found for odoo-addon-membership_extension<16.1dev,>=16.0dev
rafaelbn commented 1 year ago

Hello @sbidoul , could you please give us a clue to solve this runboat log? https://github.com/OCA/vertical-association/pull/133#issuecomment-1359665739 @yajo do you have any idea? Thank you!

sbidoul commented 1 year ago

@rafaelbn membership_extension is not merged, hence not available for installation.

fcvalgar commented 1 year ago

@carmenbianca can you rebase? please.

rafaelbn commented 1 year ago

/ocabot rebase

OCA-git-bot commented 1 year ago

@rafaelbn The rebase process failed, because command git push --force coopiteasy tmp-pr-133:16.0-mig-membership_variable_period failed with output:

remote: Permission to coopiteasy/vertical-association.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/coopiteasy/vertical-association/': The requested URL returned error: 403
carmenbianca commented 1 year ago

@rafaelbn Done.

Do you know which button I need to press to make sure that the ocabot rebase command works in the future?

sbidoul commented 1 year ago

Do you know which button I need to press to make sure that the ocabot rebase command works in the future?

I don't think there is one if the source branch belongs to an organization fork as opposed to a personal account.

pedrobaeza commented 1 year ago

Yes, it's a problem/undesired feature of GitHub, that doesn't allow maintainers to push to organization branches. Last time I checked, they don't want to change this behavior.

carmenbianca commented 1 year ago

That's a pity :( Thank you for your swift answers @sbidoul @pedrobaeza

I'll add a low-priority discussion item about this for our next internal meeting.

fcvalgar commented 1 year ago

internal @moduon MT-1834

chienandalu commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-133-by-chienandalu-bump-nobump, awaiting test results.

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 1 year ago

It looks like something changed on 16.0 in the meantime. Let me try again (no action is required from you). Prepared branch 16.0-ocabot-merge-pr-133-by-chienandalu-bump-nobump, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at e06e340927c4d85affb5a702de6a5a17bed98041. Thanks a lot for contributing to OCA. ❤️