search

OCA / vertical-association

Odoo addons for membership related tasks
GNU Affero General Public License v3.0
38 stars 112 forks source link

[16.0][FIX] membership_extension: compute membership state: old member #139

Closed PierrickBrun closed 10 months ago

PierrickBrun commented 1 year ago

To compute if the partner is an old member we should check that any kind of membership line is associated with it, not valid ones.

Before: Old members are considered Non member

After: Old members status is applied correctly

rafaelbn commented 1 year ago

/ocabot rebase

OCA-git-bot commented 1 year ago

@rafaelbn The rebase process failed, because command git push --force akretion tmp-pr-139:16.0-fix-old_member failed with output:

remote: Permission to akretion/vertical-association.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/akretion/vertical-association/': The requested URL returned error: 403
PierrickBrun commented 1 year ago

I rebased manually

rafaelbn commented 1 year ago

Hello @carmenbianca ! Do you agree? @fcvalgar ?

PierrickBrun commented 1 year ago

After my functional review I detect:

The use case where the membership does not have a period the field "current membership status" is not calculated well.

What do you think @PierrickBrun ?

I did not notice this, thank you. Indeed I think in that case the partner should have the "paid member" status

rafaelbn commented 1 year ago

Hello @chienandalu @carmenbianca , do you wanna review?

github-actions[bot] commented 11 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.