[16.0][FIX] membership_extension: replace categories field by category_ids

OCA / vertical-association

Odoo addons for membership related tasks

GNU Affero General Public License v3.0

38 stars 112 forks source link

[16.0][FIX] membership_extension: replace categories field by category_ids #140

Closed PierrickBrun closed 1 year ago

PierrickBrun commented 1 year ago

The membership categories Char field has some drawbacks, the main one being not supporting translations.

Apparently replacing the filter on membership_categories by a filter on membership_category_ids just works, looking at the git history this field was added in Odoo 8.0 and not updated since, I suspect that it exists to circumvent an odoo limitation that does no longer exists.

I've removed the field and I don't find any regression so I guess this would be easier to remove it and use membership_category_ids everywhere instead.

github-actions[bot] commented 1 year ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

pedrobaeza commented 1 year ago

/ocabot merge major

OCA-git-bot commented 1 year ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-140-by-pedrobaeza-bump-major, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at f7afb5acc7f0e216d333d8addc5ccb1104fe61de. Thanks a lot for contributing to OCA. ❤️