search

OCA / vertical-association

Odoo addons for membership related tasks
GNU Affero General Public License v3.0
38 stars 112 forks source link

[15.0][FIX] membership_extension: Don't return early #163

Open pedrobaeza opened 8 months ago

pedrobaeza commented 8 months ago

Follow-up of #159 after not getting answer

Don't return before consuming whole recordset.

@Tecnativa

AlbertCabedo commented 8 months ago

+1

OCA-git-bot commented 5 months ago

This PR looks fantastic, let's merge it! Prepared branch 15.0-ocabot-merge-pr-163-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot commented 5 months ago

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-163-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot commented 5 months ago

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-163-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

rafaelbn commented 5 months ago

/ocabot rebase

OCA-git-bot commented 5 months ago

@rafaelbn The rebase process failed, because command git push --force Tecnativa tmp-pr-163:15.0-fix-membership_extension-compute_state failed with output:

remote: Permission to Tecnativa/vertical-association.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/Tecnativa/vertical-association/': The requested URL returned error: 403
rafaelbn commented 5 months ago

@pedrobaeza you can merge this FIX but test are failing

pedrobaeza commented 5 months ago

Tests failing is due to other module (and main branch is also red). It's in my backlog to fix the branch, but not able to do it for now.

gaikaz commented 5 months ago

I was about to create a PR for the exact fix on 16.0 Could we get this merged and forward-ported?

github-actions[bot] commented 3 weeks ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.