OCA / vertical-association

Odoo addons for membership related tasks

GNU Affero General Public License v3.0

38 stars 112 forks source link

Closed chienandalu closed 7 years ago

chienandalu commented 7 years ago

Contract Membership Delegated Partner

This module allows to set the delegated membership at the contract so the recurring invoices automatically have it set.

Depends on:

cc @Tecnativa

rafaelbn commented 7 years ago

chienandalu commented 7 years ago

@pedrobaeza Changes done

pedrobaeza commented 7 years ago

Check Travis status

chienandalu commented 7 years ago

chienandalu commented 7 years ago

@pedrobaeza @rafaelbn Ready to review (if runbot lets it)

pedrobaeza commented 7 years ago

Please rebase to have the dependent module

chienandalu commented 7 years ago

@pedrobaeza @rafaelbn All green now

chienandalu commented 7 years ago

@pedrobaeza Test changed

pedrobaeza commented 7 years ago

You haven't understood me well:

First you need to modify contract tests for having the dual classes. I have done it in this PR: https://github.com/OCA/contract/pull/105
Then you need to adapt tests of this module for minimizing the new created objects and only checks the things that correspond to the module. See 7fece17444b67012e3165ec96ab076284b938c01 with the reduce test.

Unfortunately, tests are failing on contract side due to another bug in main branch. We will restart this when the problem is fixed.

pedrobaeza commented 7 years ago

Relaunching now that OCA/contract#105 has been merged.

pedrobaeza commented 7 years ago

@rafaelbn Travis was red due to some things I forgot to change in the redone tests. Now it's green and I'll merge after my review and yours.