OCA / vertical-association

Odoo addons for membership related tasks
GNU Affero General Public License v3.0
38 stars 112 forks source link

[11.0] membership_delegated_partner: Migration to 11.0 #46

Closed chienandalu closed 6 years ago

chienandalu commented 7 years ago

Membership Delegated Partner

This module allows to delegate a membership line to a partner independently of the invoicing partner.

cc @Tecnativa

chienandalu commented 7 years ago

Travis LINT fails:

FileNotFoundError: [Errno 2] No such file or directory: '/home/travis/virtualenv/python3.4.6/lib/python3.4/site-packages/six-1.10.0.dist-info/METADATA'
pedrobaeza commented 7 years ago

@moylop260 @Yajo Any clue about the error?

moylop260 commented 7 years ago

Let’s to try changing to py3.5

pedrobaeza commented 7 years ago

Thanks, that's it! I forgot that this repository was the first that I created the branch and it was with 3.4.

pedrobaeza commented 7 years ago

@luismontalba @rafaelbn please review

chienandalu commented 7 years ago

Thanks @moylop260 :smile:

luismontalba commented 7 years ago

Please, help me to understand this issue: 1) I give demo user permission. "Delegated partner in membership" 2) I log in with demo user 3) I create a member (TestMember) an fill membership features:

testmember

4) I clic smart button "Invoiced" 5) I create a new invoice with a delegated member and validate it:

invoice

6) I go to the delegated member and there aren't any invoice:

noinvoiced

chienandalu commented 7 years ago

@luismontalba It only delegates the membership (membership tab). The invoiced partner remains the same.

luismontalba commented 7 years ago

OK, thanks! I was confused about case when creating a new invoice ...

rafaelbn commented 7 years ago

Hello @luismontalba , please review README https://github.com/OCA/vertical-association/pull/46/files#diff-7813fda9b409734cb955878e86e4853dR18 if something is not clear or you can improve it tell us please! Thanks! 😄

rafaelbn commented 6 years ago

Please @chienandalu review that all FIX and IMP from 10.0 are here in v11. And confirm me before merging. Thanks

chienandalu commented 6 years ago

@moylop260 Any idea of why travis and runbot may be failing here?

pedrobaeza commented 6 years ago

Please rebase this

chienandalu commented 6 years ago

At last! I had to move @moylop260 to the top of the rebase and then the build seems to be happy now

chienandalu commented 6 years ago

Can we merge then?