search

OCA / vertical-association

Odoo addons for membership related tasks
GNU Affero General Public License v3.0
38 stars 112 forks source link

[MIG] membership_variable_period: Migration to 12.0 #69

Closed chienandalu closed 5 years ago

chienandalu commented 5 years ago

cc @Tecnativa

nikul-serpentcs commented 5 years ago

@chienandalu Fix Transifex commit's OCA Transbot updated translations from Transifex

chienandalu commented 5 years ago

@chienandalu Fix Transifex commit's OCA Transbot updated translations from Transifex

@nikul-serpentcs That's the history of the module. What do you want me to fix there?

nikul-serpentcs commented 5 years ago

@nikul-serpentcs That's the history of the module. What do you want me to fix there?

Because It's not needed anywhere, Only Increase the number of Commit's

chienandalu commented 5 years ago

Because It's not needed anywhere, Only Increase the number of Commit's

We only squash transifex consecutive commits (or event author/logical commits). Otherwise we let history as it is

pedrobaeza commented 5 years ago

Yes, if you see my usual text is:

Please squash together adjacent "OCA Transbot.." commits using https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

so I see this one correct.