search

OCA / vertical-association

Odoo addons for membership related tasks
GNU Affero General Public License v3.0
38 stars 112 forks source link

[10.0][FIX] membership_variable_period - fixing ensure_one() error on product.template write #90

Closed baimont closed 4 years ago

baimont commented 4 years ago

fixes https://github.com/OCA/vertical-association/issues/89

pedrobaeza commented 4 years ago

Although technically correct, this will affect the performance a lot. I would check if there's any membership_type and then perform the call to super independently. If not, call super for all of them together.

pedrobaeza commented 4 years ago

Let's fast-track it

/ocabot merge patch

OCA-git-bot commented 4 years ago

This PR looks fantastic, let's merge it! Prepared branch 10.0-ocabot-merge-pr-90-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 4 years ago

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-90-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza commented 4 years ago

/ocabot merge patch

OCA-git-bot commented 4 years ago

This PR looks fantastic, let's merge it! Prepared branch 10.0-ocabot-merge-pr-90-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 4 years ago

Congratulations, your PR was merged at 983ef19674073f6444662db645e075f2faecf599. Thanks a lot for contributing to OCA. ❤️

pedrobaeza commented 4 years ago

@chienandalu is this affecting 11.0 / 12.0 ?

chienandalu commented 4 years ago

Looks like it does.

pedrobaeza commented 4 years ago

OK, cherry-picked for v12 in 651f1d0f91ed86dac29038f7b8c6f58a56de5447 and v11 in b9b09dd503f977d103df1a94d77fc482a162c3df, and I see that @astirpe has included it as well in v13 migration.