OCA / vertical-ngo

Odoo for NGO's and humanitarian organization
GNU Affero General Public License v3.0
31 stars 62 forks source link

[ADD] module logistic_order_multicurrency #108

Closed yvaucher closed 9 years ago

yvaucher commented 9 years ago

This module shows amounts in company currency bellow total amount on logistic order It also show currency in list view.

gurneyalex commented 9 years ago

could you add an automated test?

yvaucher commented 9 years ago

@gurneyalex added tests

gurneyalex commented 9 years ago

error in test code, I think vertical-ngo/logistic_order_multicurrency/tests/test_amount_total_co.py", line 61, in test_amount_other_currency

--> AttributeError: 'module' object has no attribute 'now'

yvaucher commented 9 years ago

@gurneyalex fixed

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.16%) to 76.82% when pulling e1b51c0d5da34f47ae9100899ac7a1b317bc3b15 on yvaucher:8.0-add-logistic_order_multicurrency into f68632c14362b0ef234c8c51b1778f78bbab0d88 on OCA:8.0.

jgrandguillaume commented 9 years ago

Tested. +1 when .pot file is updated

lepistone commented 9 years ago

:+1: for me, too. @yvaucher ping me for a merge when the translation is up to date. Thanks!

yvaucher commented 9 years ago

updated pot file

guewen commented 9 years ago

@yvaucher seems that some values still miss in the pot file, I don't see

+ string="Total in Company currency",
+ help="Total converted to company currency at today's rate."
yvaucher commented 9 years ago

@guewen Odoo didn't generated them :disappointed:

Maybe it is because they aren't displayed in view.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.17%) to 74.64% when pulling 723a65190316ecb1da237b9a54aa0b1edca2c961 on yvaucher:8.0-add-logistic_order_multicurrency into 97bd0b6f9e251cab1fa914aba7d00837c9541ad7 on OCA:8.0.

yvaucher commented 9 years ago

@ehdem Hello thanks for the review, it is a good idea to make sure help texts are added to fields. However, in current case, those fields are there for computation and using money widget. They aren't displayed to the user. So a user wouldn't have access to that help message.

lepistone commented 9 years ago

I tried myself to generate the translation files on a clean database, and I get the exact same result (I took the occasion to add a french stub). So @guewen I don't see any problem here, and don't know why a few strings seem missing.

I'm merging as soon as the build is green. Thanks to all!

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.17%) to 74.59% when pulling dbd1a7e25ceb5440723d050290bec716daf48ed8 on yvaucher:8.0-add-logistic_order_multicurrency into d148b0e17b81654a540d03785e8a42184a06fd4a on OCA:8.0.

lepistone commented 9 years ago

Like we discussed on #115, I updated fr.po to have empty strings.

yvaucher commented 9 years ago

@lepistone thanks!

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.17%) to 74.59% when pulling d2bec6e78bd3fce646959796fbc292ef89bbe357 on yvaucher:8.0-add-logistic_order_multicurrency into d148b0e17b81654a540d03785e8a42184a06fd4a on OCA:8.0.

ehdem commented 9 years ago

@yvaucher: thank, you are right, but I think it is a way to help developper to know the field definition.