Closed yvaucher closed 9 years ago
could you add an automated test?
@gurneyalex added tests
error in test code, I think vertical-ngo/logistic_order_multicurrency/tests/test_amount_total_co.py", line 61, in test_amount_other_currency
--> AttributeError: 'module' object has no attribute 'now'
@gurneyalex fixed
Tested. +1 when .pot file is updated
:+1: for me, too. @yvaucher ping me for a merge when the translation is up to date. Thanks!
updated pot file
@yvaucher seems that some values still miss in the pot file, I don't see
+ string="Total in Company currency",
+ help="Total converted to company currency at today's rate."
@guewen Odoo didn't generated them :disappointed:
Maybe it is because they aren't displayed in view.
@ehdem Hello thanks for the review, it is a good idea to make sure help texts are added to fields. However, in current case, those fields are there for computation and using money widget. They aren't displayed to the user. So a user wouldn't have access to that help message.
I tried myself to generate the translation files on a clean database, and I get the exact same result (I took the occasion to add a french stub). So @guewen I don't see any problem here, and don't know why a few strings seem missing.
I'm merging as soon as the build is green. Thanks to all!
Like we discussed on #115, I updated fr.po
to have empty strings.
@lepistone thanks!
@yvaucher: thank, you are right, but I think it is a way to help developper to know the field definition.
This module shows amounts in company currency bellow total amount on logistic order It also show currency in list view.