Question : purpose of this verticalisation?

OCA / vertical-travel

GNU Affero General Public License v3.0

33 stars 75 forks source link

Question : purpose of this verticalisation? #32

Open houssine78 opened 9 years ago

houssine78 commented 9 years ago

I can't figure out what this verticalisation will manage... does is the management of a travel agency or all the aspects of the business travel for employee of a company?

yvaucher commented 9 years ago

Indeed https://github.com/OCA/vertical-travel/blob/8.0/README.md needs some love

01Solene commented 9 years ago

Hi Houssine78,

This module will help you to manage the travel of yours employees. So the answer is the second part of your question.

Have fun to try it !

houssine78 commented 9 years ago

Hey @yvaucher, we should call this file HUGME.md

houssine78 commented 9 years ago

Thanks @01Solene I'll play a bit and maybe try to port some modules on v8... any recommandation or short explanation on how to proceed?

fork, work on it and make a pull request?

bwrsandman commented 9 years ago

Hey @houssine78, thanks for taking up this responsibility. I am the author of most of the v7 modules. If you need technical help with any of the modules feel free to contact me and I will be happy to help.

Have a look at https://github.com/nbessi/odoo_new_api_guideline, it is a very good resource for the v8 porting process as the API has changed.

bwrsandman commented 9 years ago

The most interesting modules are the following:

travel_journey
travel_accommodation
travel_rental_car
travel_rental_service

You need to move the modules out of __unported__ and set them to installable. These are the v7 modules from when the module was created, they might be behind on commits, so the first thing you should do is check that against the 7.0 branch.

houssine78 commented 9 years ago

Hi @bwrsandman ! thanks for the info!

In fact I wasn't planning to port it to the new api but to V8 which still support the old api. It may be a to step migration first v7 to v8 and pop it up from unported folder and then migrate it to the new api.

I'm running out of time and I'm afraid that I could not do it in one phase.

Anyway I will come to you if I've any question!

bwrsandman commented 9 years ago

Keep in mind that the automated tests check for pep8 and do test coverage analysis too.

Sorry to hear about your time constraints. Any contribution helps.

Don't worry if you can't do a full conversion, someone else will add to your contribution.

houssine78 commented 9 years ago

Yeah I was getting a look at pep8! Thanks!