search

OCA / vertical-travel

GNU Affero General Public License v3.0
33 stars 74 forks source link

[14.0][MIG] passport expiration #58

Closed damdam-s closed 2 years ago

ivantodorovich commented 3 years ago

Isn't it worth moving this module https://github.com/OCA/hr ?

At first glance it seems that's a better repo for this module. The module should be renamed to hr_employee_passport_expiration_date, *_expire_date or similar

damdam-s commented 3 years ago

@OCA/vertical-travel-maintainers do you mind if I move this module to oca/hr repo?

@ivantodorovich that was my initial idea and then I saw this module existed in this repo. BTW, no move since ages in this repo so let's wait the maintainers answer. if no answers, I will move it to oca/hr by the end of the month

OCA-git-bot commented 3 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dreispt commented 2 years ago

/ocabot merge nobump

OCA-git-bot commented 2 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-58-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot commented 2 years ago

Congratulations, your PR was merged at ad71a0ddda494e4cb55d5f5ea0c41dedff0d1d99. Thanks a lot for contributing to OCA. ❤️