search

OCA / web

Odoo web client UI related addons
GNU Affero General Public License v3.0
912 stars 1.86k forks source link

[17.0] [MIG] web_notify #2747

Open Nikul-OSI opened 6 months ago

Nikul-OSI commented 6 months ago

Hii @lmignon @pedrobaeza Can you please review this PR?

pedrobaeza commented 6 months ago

/ocabot migration web_notify

I don't know enough about the module itself.

Nikul-OSI commented 6 months ago

@shepilov-vladislav @kevinkhao @chienandalu Can you please take a look?

lmignon commented 6 months ago

@Nikul-OSI Why are all the commit prefixed with [PATCH X/Y]? Can we avoid this prefix?

Nikul-OSI commented 6 months ago

commit prefixed with [PATCH X/Y]

@lmignon I captured only preserve history, I don't why it happens.

Using git format-patch --stdout origin/17_mig_nc_web_notify..ups/16.0 -- web_notify | git am -3 --keep

same commend I used others repo. too, but not add prefixed.

Nikul-OSI commented 6 months ago

@Nikul-OSI Why are all the commit prefixed with [PATCH X/Y]? Can we avoid this prefix?

Fixed Prefix, Ready to review.

kobros-tech commented 2 months ago

I can review and contribute as I have made the same upgrade to version 17, but people in OCA sent me this PR so it is better to cooperate to publish it.

I checked all parts that need to be modified in order to make the upgrade successful, and I see they are met.

if the author @Nikul-OSI needs to recheck or inspect my upgrade, here is my module:

https://github.com/kobros-tech/web_notify/tree/main

lbisiach commented 2 months ago

@Nikul-OSI Do you estimate when you are going to close this PR ?

Nikul-OSI commented 2 months ago

@Nikul-OSI Do you estimate when you are going to close this PR ?

Yes, I reviewed, can you please create new PR. Thank you