Closed SodexisTeam closed 2 months ago
Much better now. Actually we have attempted migration of this as well and came to very similar result. Few remarks on your version:
Boolean works. Tested with #2782.
Do all others I mentioned work for you? Because they still do not for me... Please see my comments above.
Here is my testing:
@Rad0van Feel free to clone the PR and make a new commit with your desired changes. Then I guess @SodexisTeam can add it to this PR.
Which of the two PRs should we use? 🤔 This or https://github.com/OCA/web/pull/2744
@SodexisTeam @norlinhenrik
Here is my testing:
- Totals get recomputed correctly.
- Cell alignment is to the right.
- Float sums: 2 decimals. Integer sums: 0 decimals.
- Boolean field stuff: not sure what to test.
@Rad0van Feel free to clone the PR and make a new commit with your desired changes. Then I guess @SodexisTeam can add it to this PR.
Totals get recomputed - nice! Alignment is almost OK - the totals are getting away slightly - see attached picture. Haven't tested integers and booleans yet.
Which of the two PRs should we use? 🤔 This or #2744
@SodexisTeam @norlinhenrik
We use this PR. I just closed #2744.
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
/ocabot migration web_widget_x2many_2d_matrix
What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-2756-by-pedrobaeza-bump-nobump, awaiting test results.
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
Congratulations, your PR was merged at 63e85a1051f17afb041fd12dc6ca649929849b46. Thanks a lot for contributing to OCA. ❤️
This does not work at all - it crashes upon loading. Have you tested it at all?