Closed jethavadakshal closed 2 weeks ago
/ocabot migration web_dialog_size
Please take car about the PR title for being proper, or it won't appear on searches over the module name.
Hello @pedrobaeza , Thanks for your quick response on this PR. can you please guide me as to why the last 2 checks failed? Also is there anything missing in this module or is it not properly migrated?
Don't worry about the codecov thing. It's just a quality measure about the test coverage. It's not mandatory to comply with it.
Now the PR should be reviewed by people, as stated in https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md
Thanks, @pedrobaeza The document you provided is really helpful. From now onward I will take care of the things which are written in documentation while contributing to OCA.
Hello @CarlosRoca13, i have checked the doc shared by you. and I tried my best to perform the steps. can you please check and if it's incorrect please guide me on this. Thanks
The steps are:
$ git clone https://github.com/OCA/$repo -b 17.0
$ cd $repo
$ git checkout -b 17.0-mig-$module origin/17.0
$ git format-patch --keep-subject --stdout origin/17.0..origin/16.0 -- $module | git am -3 --keep
$ pre-commit run -a # to run pre-commit linters and formatters (please ignore pylint errors at this stage)
$ git add -A
$ git commit -m "[IMP] $module: pre-commit auto fixes" --no-verify # it is important to do all the formatting in one commit the first time
Then apply your changes and finally commit your changes to force push to this branch. :smile: The importance of doing this is to ensure that the work done by other contributors is not forgotten.
And please avoid multiples commits for the migration process to avoid noice, your commits on the migration should be 2:
[IMP] $module: pre-commit auto fixes
[MIG] $module: Migration to 17.0
Superseded by #2919