[17.0][MIG] web_favicon: Migration to 17.0

OCA / web

Odoo web client UI related addons

GNU Affero General Public License v3.0

912 stars 1.86k forks source link

[17.0][MIG] web_favicon: Migration to 17.0 #2770

Closed dc-oerp closed 4 months ago

dc-oerp commented 5 months ago

preserve commit history from V12 to V17

Previously in this PR: https://github.com/OCA/web/pull/2765#issuecomment-1989168258

dc-oerp commented 5 months ago

Hi @pedrobaeza

I have closed the other PR and created a new PR here, Please let me know if there is still any issue with this migration.

Thank you

pedrobaeza commented 5 months ago

/ocabot migration web_favicon

pedrobaeza commented 5 months ago

Please check CI

dc-oerp commented 5 months ago

All fixed

dc-oerp commented 4 months ago

Hi @pedrobaeza

Thanks for the comments. I faced one issue where after I fixed the comments, and ran pre-commit locally, it passed without any issues. However, after I pushed the code, it showed that there was an issue with Pylint.

Could you please take a look?

Thanks

OCA-git-bot commented 4 months ago

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-2770-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 4 months ago

Congratulations, your PR was merged at 48fe12976ad1c367ef3f0b1e6768d6bebf7a105a. Thanks a lot for contributing to OCA. ❤️