search

OCA / web

Odoo web client UI related addons
GNU Affero General Public License v3.0
912 stars 1.86k forks source link

[17.0][MIG] web_tree_dynamic_colored_field #2771

Closed dz0 closed 5 months ago

dz0 commented 5 months ago

My bad, didn't test for the last time -- was a typo/gotcha (now fixed).

OCA-git-bot commented 5 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AndreuOForgeFlow commented 5 months ago

@dz0, also please squash the last 2 commits. A migration can only have the pre-commit commit and the migration commit. And change the title of the PR to the name of the module: web_tree_dynamic_colored_field

dz0 commented 5 months ago

please squash the last 2 commits.

done

And change the title of the PR to the name of the module: web_tree_dynamic_colored_field

done :)

AndreuOForgeFlow commented 5 months ago

please squash the last 2 commits.

done

And change the title of the PR to the name of the module: web_tree_dynamic_colored_field

done :)

Perfect, thank you for the changes!

I guess this is ready to merge, @etobella?

etobella commented 5 months ago

/ocabot merge nobump

OCA-git-bot commented 5 months ago

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-2771-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot commented 5 months ago

Congratulations, your PR was merged at bc43787c65b1c6ed5933dcd956aa9bcded3d5434. Thanks a lot for contributing to OCA. ❤️

zamberjo commented 4 months ago

Hi @dz0! can you backport to v16.0¿?

dz0 commented 4 months ago

Hi @dz0! can you backport to v16.0¿?

Not sure if will find time soon.
My company intends to use it only in v17.

Maybe you can try same code in v16 (just change version in manifest)?

cvinh commented 2 months ago

@zamberjo can you please review the backport PR from 17.0 to 16.0 https://github.com/OCA/web/pull/2873