Closed houzefa-abba closed 5 months ago
Hi @tarteo, some modules you are maintaining are being modified, check this out!
Well, if rebased after #2776, on the cron view
Hi rebase is done
The demo cron view uses single points, so it allows testing hover highlight color but not text overflow:
I then edited the "ir.cron timeline" view on runboat to change:
date_start="nextcall"
to:
date_start="create_date" date_stop="nextcall"
Now items are displayed with range boxes instead of single points, and we can see text overflow works:
Before this PR, the "Mail: Fetchmail Service" text for example would be completely invisible as its range box is so small
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
/ocabot merge patch
What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-2775-by-pedrobaeza-bump-patch, awaiting test results.
Congratulations, your PR was merged at d891f17f5c9389075b9752a7f5c859bb1762284d. Thanks a lot for contributing to OCA. ❤️
When an item label does not fit in its date-range box, overflow according to https://visjs.github.io/vis-timeline/examples/timeline/items/rangeOverflowItem.html
Previous CSS code was already trying to do that, but was selecting
.vis-item.vis-item-content
instead of.vis-item .vis-item-content
.Displaying overflow text brings up layout issues solved by removing the forced-100% width instruction.
This change also adds highlight when hovering a box, which is useful on text that has overflown (as it has no borders).
In screenshots below I added an end date close to the start date on the first 2 tasks. They almost have the same dates, to make sure the vis lib handles them correctly (they don't step on each other).
Before: labels cut
After: labels overflow
With hover highlight