search

OCA / web

Odoo web client UI related addons
GNU Affero General Public License v3.0
897 stars 1.84k forks source link

[17.0][MIG] web_chatter_position: Migration to 17.0 #2833

Open Jp-alitec opened 1 month ago

Jp-alitec commented 1 month ago

Migrated to V17.

Jp-alitec commented 1 month ago

hey @legalsylvain @chienandalu @CRogos i have closed the previous PR (#2826) and created this new one following every guideline , can you please review?

Rad0van commented 1 month ago

This does not work at all for me. It breaks My Preferences dialog completely and I have a feeling it breaks other dialogs as well. Teste on fresh clean 17.0 It is compileForm(el, params) function breaking it... image

Jp-alitec commented 1 month ago

@Rad0van Oh ! its because of the optional chaining (https://github.com/OCA/web/pull/2833/commits/12b405bc65130ff15204bfb73c0f194f05182e27) if (child.attributes?.name?.value !== "button_box") { append(form, this.compileNode(child, params)); } I have fixed this and code is working as expected but , the optional chaining is not accepted by pre-commit !! as soon as i update this, it fails , what should i do to fix that ?

MihranThalhath commented 1 month ago

image checked on runboat and this is how it looks on invoice view

duyquyen96 commented 1 month ago

@Jp-alitec PR https://github.com/OCA/web/pull/2795#issue-2242298187 Does this have any effect on PR?

dustinhoanghavi commented 3 weeks ago

@Jp-alitec In the Invoice view form, I see duplicate chatter, can you fix it? It could be even better. Thank you! image

tva-subteno-it commented 1 week ago

Hi, I tried this module for myself because one my client needs it. It works really well on my end, with no bug. You only have the pre-commit formatting left to do. What is the stage of progress of this PR?