search

OCA / web

Odoo web client UI related addons
GNU Affero General Public License v3.0
897 stars 1.84k forks source link

[17.0][MIG] web_select_all_companies: Migration to 17.0 #2834

Open Jp-alitec opened 1 month ago

Jp-alitec commented 1 month ago

Migrated to V17

CRogos commented 1 month ago

here is also another PR: https://github.com/OCA/web/pull/2798

Jp-alitec commented 1 month ago

@CRogos Merge/squash done .

Also in this PR i have tested "when you click the very first time, it is not working" this issue is not there. Also it has some additional style changes that differ from V16 (the font size , hover styles ).

also i think in the existing PR #2798 branches might not be get selected from this functionality whereas in this PR that issue is also fixed.

image

Jp-alitec commented 1 month ago

@legalsylvain Please review.

yannoliv commented 1 month ago

Hey! I am the guy from the other PR #2798. I have tested both our implementations on runboat and they are practically the same. Our solution looks very similar.

Jp-alitec commented 1 month ago

Hey! I am the guy from the other PR #2798. I have tested both our implementations on runboat and they are practically the same. Our solution looks very similar.

@yannoliv try to create branches and then select all companies, there the difference will be visible.

Jp-alitec commented 3 weeks ago

@legalsylvain @CRogos What is the next step to get this PR merged ?