[17.0][FIX] web_m2x_options: Error when installing employee module

[CRogos]

When web_m2x_options is installed, and you install the employee module, you cannot open the employee app and get this error message (development mode needs to be active):

The components Many2OneAvatarUserField and KanbanMany2OneAvatarUserField causing this error.

I am not sure if this is the best solution, because it also changes the dependency from "web" to "mail". Review feedback highly welcome.

[CarlosRoca13]

Are you sure the problem is with this module? I've installed it with hr locally and haven't had any issue (all without including your changes).

Do you have any extra module installed on your instance?

[CRogos]

I could reproduced the issue in runbot, by installing the hr module.

But I just realized this issue only occurs in the development mode! (?debug=1)

http://oca-web-17-0-f4885276a6e4.runboat.odoo-community.org/web?debug=1#menu_id=106&action=160&model=res.partner&view_type=form

[pedrobaeza]

It seems that we will have the same problem with any other custom m2o widget, isn't it? Can't we do anything that don't force to declare that extra options on each widget?

[CarlosRoca13]

I think it's not possible to make it more abstract... I have tried different options to avoid that extensions but nothing works... @chienandalu do you have any ideas to avoid them?

[CarlosRoca13]

Yes, I tried changing the order of asset loading, but I wasn't able to make the error go away.

[chienandalu]

What about using patch(): https://github.com/odoo/documentation/blob/17.0/content/developer/reference/frontend/javascript_reference.rst?plain=1#L168-L169

[chienandalu]

What about using patch(): https://github.com/odoo/documentation/blob/17.0/content/developer/reference/frontend/javascript_reference.rst?plain=1#L168-L169

An example: https://github.com/OCA/OCB/blob/5eb4c06a5d26476cd47cfff0df23d5e05f5318b6/addons/sms/static/src/components/phone_field/phone_field.js#L8-L21

[CarlosRoca13]

Ups :sweat_smile:

[CarlosRoca13]

I will try it, I have tried with patch but patching the props directly

[CRogos]

Any idea why this only occur in developer mode?

[CarlosRoca13]

Any idea why this only occur in developer

Sometimes non-blocking errors are hidden to users, so they are only visible to developers. However, this doesn't mean they shouldn't be fixed.

[CarlosRoca13]

What about using patch(): https://github.com/odoo/documentation/blob/17.0/content/developer/reference/frontend/javascript_reference.rst?plain=1#L168-L169

It does not work either

[CRogos]

@CarlosRoca13 @chienandalu can we go with this solution as long we do not have any better way?

[CarlosRoca13]

What do you think @chienandalu?

[CRogos]

@CarlosRoca13 shall we continue without @chienandalu ? Maybe this solution is not the best, but it fixes the js error in developer mode.

[pedrobaeza]

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-2921-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at f28a0d1b26f93e8699f350ca5e1b5b35e2236d53. Thanks a lot for contributing to OCA. ❤️