[10.0] web_responsibe - Attendance Kiosk Mode won't go full page

OCA / web

Odoo web client UI related addons

GNU Affero General Public License v3.0

919 stars 1.87k forks source link

[10.0] web_responsibe - Attendance Kiosk Mode won't go full page #859

Closed Ark74 closed 6 years ago

Ark74 commented 6 years ago

Hi!,

Odoo 10 - https://github.com/odoo/odoo/commit/66e76d681d41b6c007a0394b078ddbe872989985 web_responsibe - https://github.com/OCA/web/commit/8a3afd4173f4c7a3e16d11a93bf96229d3a286b7

When installing the attendance app/module, if we launch the Kiosk Mode. The top header menu bar won't go away, I've looked for and seems like the page should become a full page with no other way to manipulate the site as for a closer behavior of a kiosk mode.

Here my only evidence where I can base this thought. https://youtu.be/m9Nbv2Xl12k?t=22s

Here the actual result: kioskmode

pedrobaeza commented 6 years ago

Yeah, I confirm the problem. Menu bar should go away.

Ark74 commented 6 years ago

Ohh, so it is how it works, cool! I thought that there was an special url or something like it, seems to me that needing to log as an Employee Officer to allow all the crew to login could be kind tricky. How can I help to fix this?

Thanks.

pedrobaeza commented 6 years ago

You need to check the JS/CSS trick that is used in standard and apply it here on web_responsive.

Ark74 commented 6 years ago

Ok, sounds simple enough :smile: , I'll start playing with with see what comes out. Thanks.

Ark74 commented 6 years ago

Hi, me again! The hr kiosk attendance mode launches fullscreen,

    <record id="hr_attendance_action_kiosk_mode" model="ir.actions.client">
        <field name="name">Attendances</field>
        <field name="tag">hr_attendance_kiosk_mode</field>
        <field name="target">fullscreen</field>
    </record>

I'm not sure but i believe this is what it calls, https://github.com/odoo/odoo/blob/cd48a806ac636806130efcf5c055f73758cb0902/addons/web/static/src/less/webclient_layout.less#L8

Seems like web_responsive has no fullscreen mode.

I've been testing adding it here, https://github.com/OCA/web/blob/dafa0a707b1bce0bdeaf25a01cf8a223deabbe06/web_responsive/static/src/less/main.less

With no result. I'll keep digging :smile:

pedrobaeza commented 6 years ago

There should be JS code that makes some changes in the DOM when it receives that target. @Yajo do you know about this?

Ark74 commented 6 years ago

@JayVora-SerpentCS could you post the fix you talked about?