7.0 remove ref to "camptocamp_logo"

[gurneyalex]

and use a more neutral 'company_logo' name (backported from 8.0 PR)

[eLBati]

:+1:

[coveralls]

Coverage remained the same when pulling f928f9e3036b1a191afca0e3f9cd7d182270c83c on gurneyalex:7.0 into d560ce5b4350ca68caa86f7c4fe9a3cbb570d51a on OCA:7.0.

[nbessi]

@pedrobaeza your option is a possibility else you have to create a new logo likle https://github.com/odoo/odoo/blob/8.0/addons/report_webkit/data.xml#L168.

The better solution will probably to patch the 8.0 branch of odoo and rename it as logo.

For the record, the header image where done as a requierment to be able to have conditional image/media in header and footer that can be managed in front end.

[nbessi]

That said creating a new logo will probably be less penalizing during migration process

[pedrobaeza]

You don't need to create any logo via XML. If you have a logo defined in your company, the expected result is to be used in any webkit report as default, as done in the other reporting engines (old RML, QWeb, and so on). If you want to use another logo, then webkit logos and XML it's the way to go.

[nbessi]

My concern about this is that it may break installation where user simply changed image in default image header. I'm not sure we can accept this PR in Version 7.0 . At least not without an announcement as it may break some installed configuration.

[lepistone]

I see your point @nbessi. Probably we should stand still on v7 (i.e. reject this PR) and do as @pedrobaeza suggests on v8. What do you think?

[pedrobaeza]

I don't think it breaks anything, because XML has <data noupdate="1"> attribute, so existing installations will remain the same.

[nbessi]

@pedrobaeza yes but wiht ${helper.embed_image('', company.logo) | n} it will use an other image the one defined in company not the one defined in the header image that was my point

[pedrobaeza]

But as header definition is not going to change on existing installations because the noupdate flag, there's no continuity problem. Remember that ${helper.embed_image('', company.logo) | n} is inside a field. It's not code, it's data.

[nbessi]

@pedrobaeza you ve got a point, but his modification will induce different behavior between default header and base report_webkit header. It is not a major issue but a pointer in manifest will be required in this case

[pedrobaeza]

OK, I agree in expanding manifest description to point this.

@gurneyalex, can you please do it?

[nbessi]

@gurneyalex @pedrobaeza as said in V8 PR you also have to have to ensure default logo dimentions will not break header. We must also specify an height and a width by default in embeed_image

[nbessi]

any news on this one

[arthru]

:+1: for the change suggested by @pedrobaeza

[pedrobaeza]

Sorry for not answering before, but I didn't see the comment.

First of all, better to use this helper method: ${helper.embed_company_logo()|safe}, that already makes all the tricks.

Secondly, the size is not going to change if your logo has the same resolution at the one hardcoded on the header, and I think we shouldn't restrict to any size, because logo tipologies are very different (some landscape, some vertical...).

[guewen]

ok for you @pedrobaeza?

[gurneyalex]

sorry for taking so much time to fix this :bow:

[pedrobaeza]

Yeah, thanks :+1:

[legalsylvain]

Hi all, it seems that this function _embed_companylogo doesn't exist in V7 serie. Or maybe I'm wrong ? I so backport the function in OCB. https://github.com/OCA/OCB/pull/450 kind regards.