OCA / website-themes

Website themes for Odoo
GNU Affero General Public License v3.0
28 stars 104 forks source link

[13.0][ADD] theme_kaizen #89

Closed tarteo closed 2 years ago

tarteo commented 3 years ago

New open-source theme.

main

kwoot commented 3 years ago

Can anybody tell me what the progress is with this? Please mail me to discuss if needed.

pedrobaeza commented 3 years ago

The module is ready. If you want it, just download the code of the PR, and you can review it:

https://odoo-community.org/page/review

tarteo commented 3 years ago

@thomaspaulb Thanks for the review :pray: Will look at your comments probably next week.

thomaspaulb commented 3 years ago

@tarteo No problem, some more comments will probably be added next week also, as I am still to look at the snippets. Am impressed with the theme so far!

tarteo commented 3 years ago

I've changed the name from theme_ipsum to theme_kaizen at the request of the customer.

raoulkramer commented 2 years ago

Hi all, could someone give me an update on what is needed to get this theme accepted. Thanks :pray:

thomaspaulb commented 2 years ago

@raoulkramer This is now finished.

The last two commits address the two remaining complaints I still had about this theme:

  1. The font was not configurable - it is still not configurable, but I've added a ROADMAP item saying so, and I'm blocking the unnecessary load of Odoo's default Google fonts when this theme is active - it just loads the Ubuntu fonts.
  2. The colors were not configurable - these are now configurable through the 'Configure this Theme' dialog box. I've also added a button to change them back to the defaults.
lfreeke commented 2 years ago

When I am in edit mode and drag and drop some blocks in to a page, afterwards when clicking on save I get this error:

Error: Uncaught TypeError: Cannot read properties of null (reading 'classList')

http://localhost:8069/web/content/502-c1127c9/1/web.assets_frontend_lazy.js:1377 Traceback: TypeError: Cannot read properties of null (reading 'classList') at http://localhost:8069/web/content/502-c1127c9/1/web.assets_frontend_lazy.js:1377:269

It happens randomly so not after every save.

thomaspaulb commented 2 years ago

@lfreeke I can't reproduce that - can you do it again but in debug=assets mode, and then send over the contents of the offending unminified JS line?

thomaspaulb commented 2 years ago

@tarteo So I think it's finally ready for merge - who is PSC here? You by any chance

tarteo commented 2 years ago

@pedrobaeza Are you by any chance PSC?

pedrobaeza commented 2 years ago

I can do the merge. That 12 commits are needed or can be squash a bit?

tarteo commented 2 years ago

@pedrobaeza Squashed them. :smile:

pedrobaeza commented 2 years ago

/ocabot merge nobump

OCA-git-bot commented 2 years ago

On my way to merge this fine PR! Prepared branch 13.0-ocabot-merge-pr-89-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 2 years ago

Congratulations, your PR was merged at d88522accbbd51633451f5ad69c017fc49343095. Thanks a lot for contributing to OCA. ❤️