Closed tarteo closed 2 years ago
Can anybody tell me what the progress is with this? Please mail me to discuss if needed.
The module is ready. If you want it, just download the code of the PR, and you can review it:
@thomaspaulb Thanks for the review :pray: Will look at your comments probably next week.
@tarteo No problem, some more comments will probably be added next week also, as I am still to look at the snippets. Am impressed with the theme so far!
I've changed the name from theme_ipsum to theme_kaizen at the request of the customer.
Hi all, could someone give me an update on what is needed to get this theme accepted. Thanks :pray:
@raoulkramer This is now finished.
The last two commits address the two remaining complaints I still had about this theme:
When I am in edit mode and drag and drop some blocks in to a page, afterwards when clicking on save I get this error:
Error: Uncaught TypeError: Cannot read properties of null (reading 'classList')
http://localhost:8069/web/content/502-c1127c9/1/web.assets_frontend_lazy.js:1377 Traceback: TypeError: Cannot read properties of null (reading 'classList') at http://localhost:8069/web/content/502-c1127c9/1/web.assets_frontend_lazy.js:1377:269
It happens randomly so not after every save.
@lfreeke I can't reproduce that - can you do it again but in debug=assets
mode, and then send over the contents of the offending unminified JS line?
@tarteo So I think it's finally ready for merge - who is PSC here? You by any chance
@pedrobaeza Are you by any chance PSC?
I can do the merge. That 12 commits are needed or can be squash a bit?
@pedrobaeza Squashed them. :smile:
/ocabot merge nobump
On my way to merge this fine PR! Prepared branch 13.0-ocabot-merge-pr-89-by-pedrobaeza-bump-nobump, awaiting test results.
Congratulations, your PR was merged at d88522accbbd51633451f5ad69c017fc49343095. Thanks a lot for contributing to OCA. ❤️
New open-source theme.