search

OCA / website

Odoo website builder addons
GNU Affero General Public License v3.0
259 stars 693 forks source link

[16.0][add] website_search_header #1000

Closed JordiBForgeFlow closed 2 months ago

JordiBForgeFlow commented 1 year ago

Adds a search in the website header

image

A search button appears. When the user presses it, it unfolds the search bar:

image

JordiBForgeFlow commented 1 year ago

@elmergforgeflow

ioans73 commented 1 year ago

I'm not sure if it's a bug, but when I do a new search, the text from the previous search is kept in the search input

website_serach_header.webm

sbiosca-s73 commented 9 months ago

@JordiBForgeFlow I believe it would be convenient to apply the changes from the attached 'patch' to improve the code and make it more scalable. changes_imp (2).txt

sbiosca-s73 commented 9 months ago

@JordiBForgeFlow I would like you to apply the proposed change in the module so that we can use that JavaScript function. If you could do that, thank you.

ElmerGForgeFlow commented 9 months ago

Changes applied ( https://github.com/ForgeFlow/website/commit/3aee7ecd4a2d6c03e57d67e10dc4423ae078c292 )

On Fri, 5 Jan 2024 at 12:40, Sergi Biosca (Studio 73) < @.***> wrote:

@JordiBForgeFlow https://github.com/JordiBForgeFlow I would like you to apply the proposed change in the module so that we can use that JavaScript function. If you could do that, thank you.

— Reply to this email directly, view it on GitHub https://github.com/OCA/website/pull/1000#issuecomment-1878535372, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHGYAQSHO6ALB42M4ZYS6DYM7REHAVCNFSM6AAAAAA3BS7N5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZYGUZTKMZXGI . You are receiving this because you were mentioned.Message ID: @.***>

-- Elmer Garcia Yavi Frontend Designer @. @.> Twitter: /elmergarcia | Linkedin: /elmergarciayavii

https://www.forgeflow.com/ https://github.com/ForgeFlow https://www.linkedin.com/company/2415389 https://www.youtube.com/channel/UC6tv8_do-x2jg2nDx4H_DnA https://twitter.com/ForgeFlow

The content of this email is confidential and intended for the recipient specified in message only. It is strictly forbidden to share any part of this message with any third party, without a written consent of the sender. If you received this message by mistake, please reply to this message and follow with its deletion, so that we can ensure such a mistake does not occur in the future.

sbiosca-s73 commented 9 months ago

@ElmerGForgeFlow After reviewing the changes you have made, it seems that it is not working correctly. In the desktopSearch JavaScript function, the changes I provided have not been applied. If you can, please correct it by considering the condition in the function that I provided changes for; it is different. Thank you.

JordiBForgeFlow commented 8 months ago

/ocabot merge nobump

OCA-git-bot commented 8 months ago

Sorry @JordiBForgeFlow you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

JordiBForgeFlow commented 8 months ago

@pedrobaeza Can you merge this one?

pedrobaeza commented 8 months ago

I don't see any review.

github-actions[bot] commented 3 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.