search

OCA / website

Odoo website builder addons
GNU Affero General Public License v3.0
254 stars 690 forks source link

[16.0][MIG] website_form_require_legal: Migration to version 16.0 #1003

Closed pilarvargas-tecnativa closed 8 months ago

pilarvargas-tecnativa commented 11 months ago

cc @Tecnativa TT44376

@chienandalu @CarlosRoca13 please review

pedrobaeza commented 11 months ago

/ocabot migration website_form_require_legal

pilarvargas-tecnativa commented 8 months ago

Something is wrong...

I tried again locally, it should no longer happen

CarlosRoca13 commented 8 months ago

I have found another error: error_classlist

pilarvargas-tecnativa commented 8 months ago

I have found another error:

is a error in the website_crm_privacy_policy module, it is corrected at https://github.com/OCA/website/pull/1014

pilarvargas-tecnativa commented 8 months ago

@CarlosRoca13 The error you were experiencing in runbot in the contact form is already fixed in the other module, however the functionality test has to be done by inserting a new form block as the other module already has the contact form customised and only allows editing the link. In local tests where the two modules do not coexist, the functionality is also applied to the contact form, so to check that it really works you would have to do it without the other module marked as "deprecated" installed.

pedrobaeza commented 8 months ago

/ocabot merge nobump

OCA-git-bot commented 8 months ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-1003-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 8 months ago

Congratulations, your PR was merged at facc049188117a90336fe5205f1a1c3d177916fb. Thanks a lot for contributing to OCA. ❤️