search

OCA / website

Odoo website builder addons
GNU Affero General Public License v3.0
254 stars 690 forks source link

[15.0][FIX] website_snippet_big_button: default links #1008

Closed pilarvargas-tecnativa closed 10 months ago

pilarvargas-tecnativa commented 10 months ago

Default links should not be set so that a user can edit where each button should redirect to so that in case of not editing the link there are no default redirects.

cc @Tecnativa TT41033

@chienandalu @CarlosRoca13 please review :)

OCA-git-bot commented 10 months ago

This PR looks fantastic, let's merge it! Prepared branch 15.0-ocabot-merge-pr-1008-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot commented 10 months ago

@pedrobaeza The merge process could not be finalized, because command git push origin 15.0-ocabot-merge-pr-1008-by-pedrobaeza-bump-minor:15.0 failed with output:

To https://github.com/OCA/website
 ! [rejected]          15.0-ocabot-merge-pr-1008-by-pedrobaeza-bump-minor -> 15.0 (fetch first)
error: failed to push some refs to 'https://***@github.com/OCA/website'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
OCA-git-bot commented 10 months ago

Congratulations, your PR was merged at b328a47f330dd5e3749340a44f4d96d543b7ce37. Thanks a lot for contributing to OCA. ❤️