OCA / website

Odoo website builder addons
GNU Affero General Public License v3.0
254 stars 690 forks source link

[16.0][MIG] website_forum_subscription: Migration to version 16.0 #1010

Closed carolinafernandez-tecnativa closed 9 months ago

carolinafernandez-tecnativa commented 9 months ago

@Tecnativa

TT45242

@pedrobaeza @chienandalu

carolinafernandez-tecnativa commented 9 months ago

Take care of bs4 -> bs5 classes changes (https://getbootstrap.com/docs/5.0/migration/#utilities)

A good custome is to use the tooling provided here to automate those checks: OCA/openupgradelib#338

Hi thanks! How can i use that tool?

chienandalu commented 9 months ago

Hi thanks! How can i use that tool?

You'll have to build a version that includes that patch and then simply:

from openupgradelib.openupgrade_160 import convert_string_bootstrap_4to5

xml = """<odoo><!-- Your xml --></odoo>"""
print(convert_string_bootstrap_4to5(xml))  # You can copy your output from the console directly
carolinafernandez-tecnativa commented 9 months ago

Hi thanks! How can i use that tool?

You'll have to build a version that includes that patch and then simply:

from openupgradelib.openupgrade_160 import convert_string_bootstrap_4to5

xml = """<odoo><!-- Your xml --></odoo>"""
print(convert_string_bootstrap_4to5(xml))  # You can copy your output from the console directly

Take care of bs4 -> bs5 classes changes (https://getbootstrap.com/docs/5.0/migration/#utilities)

A good custome is to use the tooling provided here to automate those checks: OCA/openupgradelib#338

Goord morning, Thanks for your help! I have checked and the only change was the one you detected, you can proceed to check it now FYI @pedrobaeza

pedrobaeza commented 9 months ago

/ocabot migration website_forum_subscription

OCA-git-bot commented 9 months ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-1010-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 9 months ago

Congratulations, your PR was merged at 5b846f635dfd3a581e496d126c6f20a2b47bca60. Thanks a lot for contributing to OCA. ❤️