search

OCA / website

Odoo website builder addons
GNU Affero General Public License v3.0
254 stars 690 forks source link

[17.0][MIG] website_require_login: Migration to 17.0 #1038

Closed vvro closed 3 months ago

vvro commented 3 months ago

Tested the Website Login Required addon on 17.0 and it works with no modification.

pedrobaeza commented 3 months ago

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

vvro commented 3 months ago

Okay, will try it out

vvro commented 3 months ago

@pedrobaeza This is okay? Or need something else?

pedrobaeza commented 3 months ago

I'm afraid it's not correct, as the commit history is messed up starting with the addition of all files, then revert them, etc. And you should follow the rest of the guide for what to commit and with such names. It's better that you save the work, and start again from the scratch.

Anyway, I'm just telling you about the formal things. I'm not a qualified reviewer for the module itself.

vvro commented 3 months ago

I'm afraid it's not correct, as the commit history is messed up starting with the addition of all files, then revert them, etc. And you should follow the rest of the guide for what to commit and with such names. It's better that you save the work, and start again from the scratch.

Anyway, I'm just telling you about the formal things. I'm not a qualified reviewer for the module itself.

Okay will close this PR and start over.