[14.0][REF] shopfloor_reception

OCA / wms

Warehouse Management System for advance logistic with Odoo

GNU Affero General Public License v3.0

155 stars 191 forks source link

[14.0][REF] shopfloor_reception #907

Closed vnikolayev1 closed 2 days ago

vnikolayev1 commented 4 months ago

updated shopfloor_reception - changed done_action and move the call of _action_done only into _handle_backorder. This ensures if _handle_backorder is called the picking is set to done

OCA-git-bot commented 4 months ago

Hi @JuMiSanAr, @mmequignon, some modules you are maintaining are being modified, check this out!

vnikolayev1 commented 4 months ago

@mt-software-de

mt-software-de commented 4 months ago

I don't understand what you are fixing. Can you clarify what was not working?

It is not a fix it is a refactoring. 😂 @vnikolayev1 could please update the title of this PR.

jbaudoux commented 4 months ago

It is not a fix it is a refactoring. 😂 @vnikolayev1 could please update the title of this PR.

A refactor to do what if it is not fixing nor improving anything?

mt-software-de commented 4 months ago

It is not a fix it is a refactoring. 😂 @vnikolayev1 could please update the title of this PR.

A refactor to do what if it is not fixing nor improving anything?

It is improving the Code, with this change there is only one call of picking._action_done

jbaudoux commented 2 days ago

/ocabot merge minor

OCA-git-bot commented 2 days ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-907-by-jbaudoux-bump-minor, awaiting test results.

OCA-git-bot commented 2 days ago

Congratulations, your PR was merged at 368b04b54addfcc7722ac3645ed118e8691874f3. Thanks a lot for contributing to OCA. ❤️