Engineering - Githubissues

StefanDeYoung commented 4 years ago

Recommend to make this into a development branch.

You can run orbitx>graphics>eng_gui_prototype.py directly to view the prototype. Most of the heavy lifting is in tkinter_widgets.py. I import it into eng_gui_prototype as cw because I used to call it custom_widgets.

pep8speaks commented 4 years ago

Hello @StefanDeYoung! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file orbitx.py:

Line 52:80: E501 line too long (83 > 79 characters) Line 57:80: E501 line too long (81 > 79 characters)

In the file orbitx/graphics/eng_gui.py:

Line 49:23: W292 no newline at end of file

In the file orbitx/graphics/eng_gui_prototype.py:

Line 51:80: E501 line too long (101 > 79 characters) Line 88:80: E501 line too long (80 > 79 characters) Line 91:80: E501 line too long (88 > 79 characters) Line 111:80: E501 line too long (87 > 79 characters) Line 133:33: E128 continuation line under-indented for visual indent Line 159:80: E501 line too long (84 > 79 characters) Line 160:34: E127 continuation line over-indented for visual indent Line 176:80: E501 line too long (89 > 79 characters) Line 177:80: E501 line too long (87 > 79 characters) Line 178:80: E501 line too long (90 > 79 characters) Line 181:80: E501 line too long (88 > 79 characters) Line 197:80: E501 line too long (101 > 79 characters) Line 198:80: E501 line too long (90 > 79 characters) Line 200:80: E501 line too long (84 > 79 characters) Line 201:80: E501 line too long (103 > 79 characters) Line 202:80: E501 line too long (94 > 79 characters) Line 204:80: E501 line too long (86 > 79 characters) Line 211:49: E231 missing whitespace after ',' Line 214:30: E225 missing whitespace around operator Line 214:80: E501 line too long (98 > 79 characters) Line 215:53: E127 continuation line over-indented for visual indent Line 215:80: E501 line too long (102 > 79 characters) Line 216:30: E225 missing whitespace around operator Line 216:80: E501 line too long (99 > 79 characters) Line 217:53: E127 continuation line over-indented for visual indent Line 217:80: E501 line too long (102 > 79 characters) Line 243:5: E303 too many blank lines (2) Line 245:80: E501 line too long (81 > 79 characters) Line 251:80: E501 line too long (82 > 79 characters) Line 252:80: E501 line too long (84 > 79 characters) Line 256:9: E303 too many blank lines (2) Line 263:20: E225 missing whitespace around operator Line 265:80: E501 line too long (83 > 79 characters) Line 267:45: E231 missing whitespace after ',' Line 273:80: E501 line too long (90 > 79 characters) Line 278:80: E501 line too long (96 > 79 characters) Line 279:80: E501 line too long (96 > 79 characters) Line 280:80: E501 line too long (91 > 79 characters)

In the file orbitx/graphics/flight_gui.py:

Line 495:13: E125 continuation line with same indent as next logical line Line 543:27: E131 continuation line unaligned for hanging indent Line 651:27: E131 continuation line unaligned for hanging indent

In the file orbitx/graphics/habitat.py:

Line 154:80: E501 line too long (83 > 79 characters)

In the file orbitx/graphics/tkinter_widgets.py:

Line 11:22: E261 at least two spaces before inline comment Line 26:80: E501 line too long (105 > 79 characters) Line 140:60: E231 missing whitespace after ':' Line 140:80: E501 line too long (89 > 79 characters) Line 163:36: E262 inline comment should start with '# ' Line 164:80: E501 line too long (81 > 79 characters) Line 168:9: E265 block comment should start with '# ' Line 171:9: E265 block comment should start with '# ' Line 171:80: E501 line too long (81 > 79 characters) Line 174:9: E265 block comment should start with '# ' Line 184:9: E265 block comment should start with '# '

In the file orbitx/physics/engine.py:

Line 343:30: E127 continuation line over-indented for visual indent Line 680:80: E501 line too long (80 > 79 characters) Line 853:26: E127 continuation line over-indented for visual indent

In the file orbitx/programs/__init__.py:

Line 22:1: E402 module level import not at top of file

In the file test.py:

Line 140:80: E501 line too long (97 > 79 characters) Line 221:80: E501 line too long (80 > 79 characters)

Comment last updated at 2020-07-02 00:29:57 UTC

StefanDeYoung commented 4 years ago

Will reopen this pr onto the engineering branch instead of master.

pmelanson commented 4 years ago

edit: ignore this comment

OCESS / orbitx

Engineering #103

Comment last updated at 2020-07-02 00:29:57 UTC