Space station: #27 Re-adds function annotations to flight_gui

OCESS / orbitx

Rewrite of OrbitV, maintained by Patrick, Gavin, and contributors

MIT License

10 stars 18 forks source link

Space station: #27 Re-adds function annotations to flight_gui #57

Closed goodday0404 closed 5 years ago

goodday0404 commented 5 years ago

Hi Patrick,

I reviewed your refactoring code for version check of vpython. You did similar job with me but little different with mine. I created new module 'Vpython.py' that contains python object and version check function that contains the version check code. I made it as a module in order to share just sole vpython object is shared between other class objects when Fligth_Gui class is spited into a few class. So I edited a line of code in the event loop in flight.py.

style.py just contains HTML & CSS3 codes.

Please give me your feedback later. I will update the other refactored work later.

Cheers,

pep8speaks commented 5 years ago

Hello @goodday0404! Thanks for updating the PR.

In the file flight.py, following are the PEP8 issues :

Line 182:80: E501 line too long (84 > 79 characters)

In the file orbitx/calculator.py, following are the PEP8 issues :

Line 54:79: W291 trailing whitespace

In the file orbitx/physic_functions.py, following are the PEP8 issues :

Line 10:1: E302 expected 2 blank lines, found 1 Line 21:1: E303 too many blank lines (3) Line 38:1: E302 expected 2 blank lines, found 1 Line 70:1: W391 blank line at end of file

Comment last updated on February 28, 2019 at 20:10 Hours UTC

pmelanson commented 5 years ago

If you want, you can rebase off of code_quality, which is PR #56 , so that you don't have to pep8 format all the code. It's a little bit more work than just running the pep8 formatter, but that's why I did the work for you already and tried to send you the PR as early as I could, so you could incorporate it in your code.

pmelanson commented 5 years ago

We did a bunch of work and merged everything, sorry for polluting commit history