search

OCESS / orbitx

Rewrite of OrbitV, maintained by Patrick, Gavin, and contributors
MIT License
10 stars 18 forks source link

Add minimap showing habitat direction, position, velocity relative to reference #58

Closed pmelanson closed 5 years ago

pmelanson commented 5 years ago

Hey @sh32kim, tidied up the code. I ended up calling the vector box scene the 'minimap', and putting the minimap at the bottom of the caption. It's pretty finicky to put it in the middle, so I gave up. And IRL minimaps are usually in the bottom left anyway, right?

I also changed the arrows to show the velocity and direction to the reference, instead of velocity relative to reference and target, since that's what the old program did.

Once @goodday0404 and I are able to finish our work on refactoring the flight_gui code, we'll also refactor the one or two calculations we added in this PR (sorry that they interfere with the refactor!)

I'm also expecting a pep8 error on the '__init__' line and in three other comment lines, but I won't fix that because then we'll get more merge conflicts with the code quality refactor.

pep8speaks commented 5 years ago

Hello @pmelanson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-03-08 18:53:04 UTC
pmelanson commented 5 years ago

All of this code has been moved to #61 by @goodday0404 , closing