search

OCESS / orbitx

Rewrite of OrbitV, maintained by Patrick, Gavin, and contributors
MIT License
10 stars 18 forks source link

Physics refactor #59

Closed pmelanson closed 5 years ago

pmelanson commented 5 years ago

Hey Ye Qin, this branch isn't ready to merge yet but I just wanted to make this so we can easily compare what work we've done on this branch so far.

I'll make a comment saying when this is ready to merge.

In the meantime, want to take a look at what I've done and tell me what you think? So far I've just pep8 formatted (see the first commit) and also rewritten most of PhysicsEntity to have not-repeated code (the API is still the same, see the second commit).

pep8speaks commented 5 years ago

Hello @pmelanson! Thanks for updating the PR.

Line 10:1: E302 expected 2 blank lines, found 1 Line 21:1: E303 too many blank lines (3) Line 38:1: E302 expected 2 blank lines, found 1 Line 70:1: W391 blank line at end of file

Comment last updated on February 26, 2019 at 00:29 Hours UTC
pmelanson commented 5 years ago

@xxxyyyqqq12345 I added a new commit, and this branch still runs well. If you want to start work on AYSE implementation now, totally feel free to merge this branch and start your work on master.

Unfortunately test.py is broken, but I don't think anyone except me runs those tests. Also, there's a TODO in physics_state.py, but I don't think too many disruptive changes will come of it.

Let me know what you think! I've spent a lot of time on this, and now PhysicsEntity is a more important class that is automatically generated by indexing PhysicsState

For example: PhysicsState[0] or PhysicsState['Habitat'] both generate and return a PhysicsEntity