search

OCFL / ocfl-java

A Java OCFL implementation
MIT License
18 stars 12 forks source link

do not fail table creation if table already exists #62

Closed pwinckles closed 2 years ago

MormonJesus69420 commented 2 years ago

One small thing to say, if you are already making changes to the DB systems, could you also change the BLOB to MEDIUMBLOB for the inventory type in MariaDB tmpl file? Since as we discussed it turns out in practice that BLOB is too small. https://github.com/UW-Madison-Library/ocfl-java/blob/6a17748bfd87b379894b8469e05b403b478ab349/ocfl-java-core/src/main/resources/db/mariadb/ocfl_object_details.ddl.tmpl#L9

pwinckles commented 2 years ago

One small thing to say, if you are already making changes to the DB systems, could you also change the BLOB to MEDIUMBLOB for the inventory type in MariaDB tmpl file? Since as we discussed it turns out in practice that BLOB is too small.

https://github.com/UW-Madison-Library/ocfl-java/blob/6a17748bfd87b379894b8469e05b403b478ab349/ocfl-java-core/src/main/resources/db/mariadb/ocfl_object_details.ddl.tmpl#L9

Yep, I can do that. I'm off today as well, but I'll take care of it tomorrow.

MormonJesus69420 commented 2 years ago

No problem, enjoy your time off and do it whenever you have time, we are in no rush here. 🙂