OCHA-DAP / hdx-signals

HDX Signals
https://un-ocha-centre-for-humanitarian.gitbook.io/hdx-signals/
GNU General Public License v3.0
6 stars 0 forks source link

Remove overwrite_content functionality #119

Closed caldwellst closed 5 months ago

caldwellst commented 6 months ago

Previously, overwrite_content was a confusing parameter that when passed, meant that you expected existing rows of data in the signals data frame, and you would use those rows to generate new campaign content and signals. That is, you could basically not recalculate when you alert, just adjust how the content looked.

Turns out, this was way too complex, especially since recalculating when we want to alert is simple and easy and local, whereas the expensive computations are already in the content generation side. I've thus removed all of this functionality, and instead we just expect that if a dataset exists in output/indicator/signals.parquet, that it must be triaged before any new runs can happen. And if we elect to delete during triage, instead of deleting the content columns, it removes all rows so the entire data needs to be recreated. Much simpler this way I think.