search

OCHA-DAP / hdx-signals

HDX Signals
https://un-ocha-centre-for-humanitarian.gitbook.io/hdx-signals/
GNU General Public License v3.0
6 stars 0 forks source link

Hotfix signals return #122

Closed caldwellst closed 6 months ago

caldwellst commented 6 months ago

Fixes to some issues found in the code.

  1. log_info() in generate_signals() was the final statement, so the logging was the return value, instead of the dataset itself. I didn't think I could find anywhere else where that error existed.
  2. I think test being unset should always be TRUE. Runs should only be done intentionally. Are we sure we don't want test to be internal to the function, so we just use the env variable and remove the duplicated calls in each update_{indicator}.R script?
  3. I have changed it so we only throw errors on warnings when not interactive. This should allow for a lot more flexibility when interactively developing. What do you think?
  4. Some other small changes I notice when doing some runs.
caldwellst commented 6 months ago

Alright @hannahker, final two questions for you on the unresolved comments then I'll merge!