search

OCHA-DAP / hdx-signals

HDX Signals
https://un-ocha-centre-for-humanitarian.gitbook.io/hdx-signals/
GNU General Public License v3.0
5 stars 0 forks source link

why are we unioning LAC countries? #125

Closed zackarno closed 2 months ago

zackarno commented 2 months ago

Was curious why we are combining LAC countries here:

https://github.com/OCHA-DAP/hdx-signals/blob/f5159b9cf8474a615dd8568831f987c68d8e8bb7/src-static/update_iso3_sf.R#L155-L160

Wondering if they should be split like all others?

Also we have them available (individually) from Fieldmaps so shouldn't we go with those?

caldwellst commented 2 months ago

LAC is an ISO3 code used by the IPC in there data analysis used for a very specific product. https://www.ipcinfo.org/ipc-country-analysis/details-map/en/c/1156283/?iso3=SLV

However, while you have this PR, we could make sure that we maintain the border lines in the map. I realised later that this was dissolving borders which I didn't actually want to happen!

zackarno commented 2 months ago

I see.

So to clarify, in current construction (dissolved or not) they will always be mapped together. This is a.) correct, and b.) what we want?

caldwellst commented 2 months ago

Correct, correct.

caldwellst commented 2 months ago

What we want to address now is finally a way to have the country names plotted when we plot the IPC if LAC is the ISO3. We don't want the country names plotted in any other instance.