search

OCHA-DAP / hdx-signals

HDX Signals
https://un-ocha-centre-for-humanitarian.gitbook.io/hdx-signals/
GNU General Public License v3.0
5 stars 0 forks source link

check plots for protection against ggplot change to legend rendering #143

Closed zackarno closed 2 months ago

zackarno commented 2 months ago

just spent an hour trouble shooting why 2 plots in a different repo weren't working as expected.

Therefore, flagging here -- as it could effect any plot aesthetic where we want a legend class to show even if not in the data set (i.e dropped)

https://github.com/tidyverse/ggplot2/issues/5728

caldwellst commented 2 months ago

Have a look through the plotting functions. The only instance where we use factors and legends should be #136. What an annoying change!!

caldwellst commented 2 months ago

Addressed in #146.

zackarno commented 2 months ago

re-opening due to #165

caldwellst commented 2 months ago

This is not related to #165. That is because we have two separate geoms in the legend, and we would rather consolidate into 1.

zackarno commented 2 months ago

it is related as the IPC levels are getting dropped