Closed zackarno closed 8 months ago
FYI for this temporary fix I just copied the relevant code from the {ripc}
package to src/utils/ipc_get.R
and adjusted the one small sections
from:
https://github.com/OCHA-DAP/ripc/blob/bccc53c780639f2100cf214365f5741a14055db6/R/ipc_get.R#L65-L70
Temporary hotfix to deal w/ improper type conversion from
{ripc}
.Some
_percentage
columns reading as "character" some reading as "numeric" so they can't be bound together.https://github.com/OCHA-DAP/ripc/issues/7#issue-2154372435
and I've also done a PR on
{ripc}
which implements the same quick fix. Nonetheless I recommend we go w/ the internal fix here as a temporary solution for several reasons which I believe all have the same goals of using time most efficiently and reducing potential side-effects:{ripc}
would require fast push's to main on 2 separate repo's without Seths review{ripc}
, but think we can come up w/ a more robust solution for{ripc}
You can see a couple failed runs in the GHA history log, the latest manual run on this branch worked, so I think it makes sense to push as a temporary solution to get it back on a CRON schedule.