search

OCHA-DAP / hdx-signals

HDX Signals
https://un-ocha-centre-for-humanitarian.gitbook.io/hdx-signals/
GNU General Public License v3.0
5 stars 0 forks source link

use `file.path()` instead of "/" for parquet in blob? #47

Closed zackarno closed 4 months ago

zackarno commented 4 months ago

suggest using the typical file.path() instead of / to write paths for azure blob files. It might not matter in this specific context, but then again better safe than sorry.

probably can just do a search for ".parquet" in repo and replace paths like that

caldwellst commented 4 months ago

This is the opposite behaviour you want, because file.path() is designed to provide system specific file separators using fsep. Except, we ALWAYS want / because we are only reading to and from the Azure store, which is system independent, not system specific. Could use file.path(..., fsep = "/"), but might as well just use paste() at that point.

zackarno commented 4 months ago

ok got it!