search

OCHA-DAP / hdx-signals

HDX Signals
https://un-ocha-centre-for-humanitarian.gitbook.io/hdx-signals/
GNU General Public License v3.0
6 stars 0 forks source link

idea - `update_adm0_sf()` #54

Closed zackarno closed 4 months ago

zackarno commented 6 months ago

why not just update this function to create 1 geoparquet file? Then slight modification to the st_read() func like below to query the appropriate polygon(s). Would just tighten up the data storage strategy i think

sf$st_read(
  dsn = path,
  quiet = T,
  # pseudo-code for query - placeholder "layer_name" and iso3 ("BGD") values
  query="select * from \"layer_name\" where iso3 = 'BGD'"
)

if you think it's a good idea/ i could make an isolated PR or whatever you think is easiest

caldwellst commented 6 months ago

I avoided doing that because I figured we would be plagued with geometry errors. Not sure that would actually be the case though, so very happy for you to take it in if you think possible!