`cs` module not loaded in update_country_info.R

OCHA-DAP / hdx-signals

HDX Signals

https://un-ocha-centre-for-humanitarian.gitbook.io/hdx-signals/

GNU General Public License v3.0

5 stars 0 forks source link

`cs` module not loaded in update_country_info.R #55

Closed zackarno closed 4 months ago

zackarno commented 4 months ago

sort of randomly came across this issue. It seems cs module is used, but not loaded in the update_country_info.R script

https://github.com/OCHA-DAP/hdx-signals/blob/b4424719e91dd7530cb64b7392d4a404dd7e743b/src-static/update_country_info.R#L128-L131

I wonder if there is a way to quickly/automatically scan the entire repo for this kind of issue as well as circular imports.

caldwellst commented 4 months ago

Good catch. I think we should be using precommit here, but last time my R recommit was giving me a lot of trouble. Definitely something we should institute though. Will look into it.

caldwellst commented 4 months ago

Fixed.