OCHA-DAP / hdx-signals

HDX Signals
https://un-ocha-centre-for-humanitarian.gitbook.io/hdx-signals/
GNU General Public License v3.0
6 stars 0 forks source link

Enforce code styling #79

Closed caldwellst closed 6 months ago

caldwellst commented 6 months ago

To avoid me being really annoying in PRs, would be good to have code styling and checks using pre-commit. As @hannahker has noted, we can use {lintr} to lint the code and force manual edits to match the style prior to committing. We could even use {styler} to automatically adjust the code, but would need some manual edits to the system. For instance, when testing it was messing with {box} to change box::use(a/b/c) to box::use(a / b / c).

I propose that we use the tidyverse style guide. https://style.tidyverse.org/index.html

hannahker commented 6 months ago

Closed with #81