OCHA-DAP / hdx-signals

HDX Signals
https://un-ocha-centre-for-humanitarian.gitbook.io/hdx-signals/
GNU General Public License v3.0
5 stars 0 forks source link

Missing `download_shapefile` function? #89

Closed hannahker closed 3 months ago

hannahker commented 4 months ago

On running src-static/update_cities_sf.R, I get the following error:

Error in box::use(./utils/download_shapefile[download_shapefile]) : 
  unable to load module “./utils/download_shapefile”; not found in “./src-static”

Can't seem to find where this function is defined.

zackarno commented 4 months ago

it should be

box::use(../src/utils/download_shapefile[download_shapefile])

zackarno commented 4 months ago

I feel like it would be much easier if all paths in box could be in reference to the .rproj root directory. Then it would be much easier to figure out where files are. This is a nice and simple productivity boost that comes with working with R projects (.rproj), but not sure if it's normal practice when using {box}

caldwellst commented 3 months ago

Not normal practice, all are relative references. See here. I pushed a fix in #80.

hannahker commented 3 months ago

Closed with #80